From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH] scripts/runtime: Adjust the premature_failure check
Date: Tue, 31 May 2016 17:56:18 +0200
Message-ID: <20160531155617.GA11111@potion>
References: <1464692057-19348-1-git-send-email-ldoktor@redhat.com>
 <1464692057-19348-2-git-send-email-ldoktor@redhat.com>
 <20160531153747.GB30930@potion>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com,
	lvivier@redhat.com
To: =?utf-8?B?THVrw6HFoQ==?= Doktor <ldoktor@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57361 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751293AbcEaP4V (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 31 May 2016 11:56:21 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 37002627DA
	for <kvm@vger.kernel.org>; Tue, 31 May 2016 15:56:21 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160531153747.GB30930@potion>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-05-31 17:37+0200, Radim Kr=C4=8Dm=C3=A1=C5=99:
> 2016-05-31 12:54+0200, Luk=C3=A1=C5=A1 Doktor:
>> The premature_failure check fails on qemu-system-ppc64 as it uses
>> different message. This patch modifies the condition so it works
>> (hopefully) for all archs.
>> ---
>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> -    echo "$last_line" | grep -qi "could not load kernel" &&
>> +    echo "$last_line" | grep "_NO_FILE_4Uhere_" | grep -qi "no such=
 file" &&
>=20
> PPC uses "Could not open '_NO_FILE_4Uhere_': No such file [...]".
> The problem is that "No such file [...]" might be localized, so what
> about
>   grep -qi "could not \(load kernel\|open\) '_NO_FILE_4Uhere_'"
> ?

My tested local repo has a different line there:
(no idea how the posted version came around ...)

  echo "$last_line" | grep -qi "_NO_FILE_4Uhere_" &&

so we might be fine with it too, but I like the context check.