From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH v1 04/11] KVM: x86: use u16 for logical VCPU mask in lapic
Date: Fri, 1 Jul 2016 14:48:00 +0200
Message-ID: <20160701124759.GB27840@potion>
References: <20160630205429.16480-1-rkrcmar@redhat.com>
 <20160630205429.16480-5-rkrcmar@redhat.com>
 <fdc80f6b-cdb1-b1e6-a843-d5c6a75a69f5@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	"Lan, Tianyu" <tianyu.lan@intel.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>, Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <fdc80f6b-cdb1-b1e6-a843-d5c6a75a69f5@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2016-07-01 09:56+0200, Paolo Bonzini:
> On 30/06/2016 22:54, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
>> @@ -747,7 +745,7 @@ static inline bool kvm_apic_map_get_dest_lapic(s=
truct kvm *kvm, struct kvm_lapic
>>  			return true;
>> =20
>>  		lowest =3D kvm_vector_to_index(irq->vector, hweight16(*bitmap),
>> -				bitmap, 16);
>> +				(unsigned long *)bitmap, 16);
>> =20
>=20
> kvm_vector_to_index's last argument is always 16, so we might as well
> omit it and make the third argument u16* too.

The other callsite in kvm_irq_delivery_to_apic() does not pass 16:

  int idx =3D kvm_vector_to_index(irq->vector, dest_vcpus,
  			dest_vcpu_bitmap, KVM_MAX_VCPUS);

kvm_vector_to_index() uses find_next_bit(), so we would have two casts
if we changed the type.  This patch is not really needed, so I could
drop it instead.