From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Auger Eric <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, marc.zyngier@arm.com,
christoffer.dall@linaro.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, andre.przywara@arm.com, pbonzini@redhat.com
Subject: Re: [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing
Date: Fri, 8 Jul 2016 22:55:43 +0200 [thread overview]
Message-ID: <20160708205543.GC10741@potion> (raw)
In-Reply-To: <20160708085233.qjptxd4qh7ukbgl3@hawk.localdomain>
2016-07-08 10:52+0200, Andrew Jones:
> On Fri, Jul 08, 2016 at 10:16:53AM +0200, Auger Eric wrote:
>> On 07/07/2016 19:20, Andrew Jones wrote:
>> > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote:
>> >> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
>> >> @@ -29,7 +29,9 @@
>> >> #include <linux/srcu.h>
>> >> #include <linux/export.h>
>> >> #include <trace/events/kvm.h>
>> >> +#if !defined(CONFIG_ARM) && !defined(CONFIG_ARM64)
>> >> #include "irq.h"
>> >> +#endif
>> >
>> > Instead of doing this, shouldn't we add arch/arm[64]/kvm/irq.h files.
>> > Probably a simple one like ./arch/s390/kvm/irq.h ?
>>
>> Well I considered this solution in the past but I did not find much to
>> put there (it was even void). typically irqchip_in_kernel is in
>> include/kvm/arm_vgic.h since the macro can be shared between arm/arm64.
>
> I think I'd prefer a nearly empty file to the #ifdef's, but Paolo and
> Radim should chime in.
I concur, hiding ugliness in header files is what we strive for.
The files could #include <include/kvm/arm_vgic.h>, which might make
their existence easier to understand.
next prev parent reply other threads:[~2016-07-08 20:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 8:47 [RFC v6 0/6] KVM: arm/arm64: gsi routing support Eric Auger
2016-07-06 8:47 ` [RFC v6 1/6] KVM: api: pass the devid in the msi routing entry Eric Auger
2016-07-11 16:24 ` Andre Przywara
2016-07-06 8:47 ` [RFC v6 2/6] KVM: kvm_host: add devid in kvm_kernel_irq_routing_entry Eric Auger
2016-07-11 16:24 ` Andre Przywara
2016-07-06 8:47 ` [RFC v6 3/6] KVM: irqchip: convey devid to kvm_set_msi Eric Auger
2016-07-11 16:25 ` Andre Przywara
2016-07-06 8:47 ` [RFC v6 4/6] KVM: arm/arm64: enable irqchip routing Eric Auger
2016-07-07 17:20 ` Andrew Jones
2016-07-08 8:16 ` Auger Eric
2016-07-08 8:52 ` Andrew Jones
2016-07-08 20:55 ` Radim Krčmář [this message]
2016-07-14 9:36 ` Auger Eric
2016-07-11 16:25 ` Andre Przywara
2016-07-14 9:33 ` Auger Eric
2016-07-06 8:47 ` [RFC v6 5/6] KVM: arm/arm64: enable MSI routing Eric Auger
2016-07-11 16:26 ` Andre Przywara
2016-07-06 8:47 ` [RFC v6 6/6] KVM: arm: enable KVM_SIGNAL_MSI and " Eric Auger
2016-07-11 16:26 ` Andre Przywara
2016-07-14 10:00 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708205543.GC10741@potion \
--to=rkrcmar@redhat.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox