From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH 0/8] x86: audit and remove needless module.h includes
Date: Thu, 14 Jul 2016 11:18:39 -0400
Message-ID: <20160714151835.GO4194@windriver.com>
References: <20160714001901.31603-1-paul.gortmaker@windriver.com>
 <20160714130443.GA27637@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, <kvm@vger.kernel.org>,
	<x86@kernel.org>, <xen-devel@lists.xenproject.org>
To: Ingo Molnar <mingo@kernel.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20160714130443.GA27637@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

[Re: [PATCH 0/8] x86: audit and remove needless module.h includes] On 1=
4/07/2016 (Thu 15:04) Ingo Molnar wrote:

>=20
> * Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>=20
> > To that end, I have done allmodconfig, allyesconfig and allnoconfig
> > for both 32 bit and 64 bit x86 with these changes on the linux-next
> > from today, which presumably has an up to date copy of tip in it.
>=20
> It does, still I get this on allnoconfig with your patches applied:

Took me a while to figure out why I didn't see this; I was able to
finally reproduce it on x86-32 with allnoconfig but CONFIG_SMP=3Dy.

>=20
> arch/x86/kernel/setup_percpu.c: In function =E2=80=98setup_percpu_seg=
ment=E2=80=99:
> arch/x86/kernel/setup_percpu.c:159:2: error: implicit declaration of =
function=20
> =E2=80=98pack_descriptor=E2=80=99 [-Werror=3Dimplicit-function-declar=
ation]
>   pack_descriptor(&gdt, per_cpu_offset(cpu), 0xFFFFF,
>   ^
> arch/x86/kernel/setup_percpu.c:162:2: error: implicit declaration of =
function=20
> =E2=80=98write_gdt_entry=E2=80=99 [-Werror=3Dimplicit-function-declar=
ation]
>   write_gdt_entry(get_cpu_gdt_table(cpu),
>   ^
> arch/x86/kernel/setup_percpu.c:162:18: error: implicit declaration of=
 function=20
> =E2=80=98get_cpu_gdt_table=E2=80=99 [-Werror=3Dimplicit-function-decl=
aration]
>   write_gdt_entry(get_cpu_gdt_table(cpu),

All three of these guys live in asm/desc.h and adding that to the top o=
f
arch/x86/kernel/setup_percpu.c asm include list seems to fix the
reproducer I now have here.

>=20
> I'll continue testing with the setup_percpu.c change left out.

Let me know if you want a resend or if you want to just add the
asm/desc.h locally or ...

Paul.
--

>=20
> Thanks,
>=20
> 	Ingo