Re: [PATCH] powerpc: move hmi.c to arch/powerpc/kvm/

Michael Ellerman
2016-08-11T11:07:48Z

Michael Ellerman <mpe@ellerman.id.au> writes:

> Radim Krčmář <rkrcmar@redhat.com> writes:
>
>> 2016-08-03 13:36+0200, Paolo Bonzini:
>>> hmi.c functions are unused unless sibling_subcore_state is nonzero, and
>>> that in turn happens only if KVM is in use. So move the code to
>>> arch/powerpc/kvm/, putting it under CONFIG_KVM_BOOK3S_64_HANDLER
>>> rather than CONFIG_PPC_BOOK3S_64. The sibling_subcore_state is also
>>> included in struct paca_struct only if KVM is supported by the kernel.
>>>
>>> Cc: Paul Mackerras <paulus@samba.org>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>> Cc: kvm-ppc@vger.kernel.org
>>> Cc: kvm@vger.kernel.org
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> It would be nice to have this in 4.8, to minimize any 4.9 conflicts.
>>> Build-tested only, with and without KVM enabled.
>>
>> If you agree with the change, would you prefer to have this patch merged
>> through the PowerPC tree?
>
> Yeah I'll pull it into my fixes branch.

And then I pulled it out again:

(.text+0x157fc): undefined reference to `.wait_for_subcore_guest_exit'
(.text+0x15834): undefined reference to `.wait_for_tb_resync'
make[1]: *** [vmlinux] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/12775422/

cheers