kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Luwei Kang <luwei.kang@intel.com>,
	kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest
Date: Thu, 11 Aug 2016 16:40:48 +0200	[thread overview]
Message-ID: <20160811144047.GB8001@potion> (raw)
In-Reply-To: <524707457.1177454.1470921840115.JavaMail.zimbra@redhat.com>

2016-08-11 09:24-0400, Paolo Bonzini:
>> > Expose AVX512DQ, AVX512BW, AVX512VL feature to guest.
>> > Its spec can be found at:
>> > https://software.intel.com/sites/default/files/managed/b4/3a/319433-024.pdf
>> > 
>> > Signed-off-by: Luwei Kang <luwei.kang@intel.com>
>> > ---
>> >  arch/x86/kvm/cpuid.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index
>> > 7597b42..a2d007c 100644
>> > --- a/arch/x86/kvm/cpuid.c
>> > +++ b/arch/x86/kvm/cpuid.c
>> > @@ -366,7 +366,8 @@ static inline int __do_cpuid_ent(struct
>> > kvm_cpuid_entry2 *entry, u32 function,
>> >  		F(FSGSBASE) | F(BMI1) | F(HLE) | F(AVX2) | F(SMEP) |
>> >  		F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | f_mpx | F(RDSEED) |
>> >  		F(ADX) | F(SMAP) | F(AVX512F) | F(AVX512PF) | F(AVX512ER) |
>> > -		F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT);
>> > +		F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT) |
>> > +		F(AVX512DQ) | F(AVX512BW) | F(AVX512VL);
>> > 
>> 
>> Hi Paolo,
>>     What is your opinion?
> 
> Hi, the patch was sent too late for 4.8 so I just ignored it. :)  Radim
> is handling the tree now and I guess he'll get to it in the next few
> days.  It's a trivial patch, so I don't expect any issue.

F(PCOMMIT) was removed in dfa169bbee00 ("Revert "KVM: x86: add pcommit
support""), so the patch doesn't apply.

I made minor changes (see below) and queued for 4.9, thanks.

-		F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB);
+		F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(AVX512DQ) |
+		F(AVX512BW) | F(AVX512VL);

      reply	other threads:[~2016-08-11 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  8:01 [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest Luwei Kang
2016-08-11  7:32 ` Kang, Luwei
2016-08-11 13:24   ` Paolo Bonzini
2016-08-11 14:40     ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160811144047.GB8001@potion \
    --to=rkrcmar@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luwei.kang@intel.com \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).