From: "Radim Krčmář" <rkrcmar@redhat.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 0/4] MIPS: KVM: Fix MMU/TLB management issues
Date: Fri, 12 Aug 2016 14:37:22 +0200 [thread overview]
Message-ID: <20160812123721.GE8001@potion> (raw)
In-Reply-To: <cover.e70247d7d77e67a2331e65b6b7fd3894508e5d28.1470911944.git-series.james.hogan@imgtec.com>
2016-08-11 11:52+0100, James Hogan:
> These patches fix several issues in the management of MIPS KVM TLB
> faults:
>
> 1) kvm_mips_handle_mapped_seg_tlb_fault() misbehaves for virtual address
> zero, which can be hit if the guest creates such a mapping and
> accesses it in a way unexpected for the commpage (e.g. a CACHE
> instruction).
>
> 2) kvm_mips_handle_mapped_seg_tlb_fault() doesn't range check the gfn,
> allowing a high mapping by the guest to overflow the guest_pmap[].
>
> 3) kvm_mips_handle_kseg0_tlb_fault() has an off by one in its gfn range
> check, which could allow an odd sized guest_pmap[] to be overflowed.
>
> 4) some callers of kvm_mips_handle_kseg0_tlb_fault() and
> kvm_mips_handle_mapped_seg_tlb_fault() don't correctly propagate
> errors upwards.
>
> They're all marked for stable but won't apply cleanly before v4.8-rc1
> due to recent changes. I have backports ready though.
Applied, thanks.
prev parent reply other threads:[~2016-08-12 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:52 [PATCH 0/4] MIPS: KVM: Fix MMU/TLB management issues James Hogan
2016-08-11 10:58 ` [PATCH 1/4] MIPS: KVM: Fix mapped fault broken commpage handling James Hogan
2016-08-11 10:58 ` [PATCH 2/4] MIPS: KVM: Add missing gfn range check James Hogan
2016-08-11 10:58 ` [PATCH 3/4] MIPS: KVM: Fix gfn range check in kseg0 tlb faults James Hogan
2016-08-11 10:58 ` [PATCH 4/4] MIPS: KVM: Propagate kseg0/mapped tlb fault errors James Hogan
2016-08-12 12:37 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812123721.GE8001@potion \
--to=rkrcmar@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox