From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 0/4] MIPS: KVM: Fix MMU/TLB management issues Date: Fri, 12 Aug 2016 14:37:22 +0200 Message-ID: <20160812123721.GE8001@potion> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Ralf Baechle , linux-mips@linux-mips.org, kvm@vger.kernel.org, stable@vger.kernel.org To: James Hogan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53726 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbcHLMhZ (ORCPT ); Fri, 12 Aug 2016 08:37:25 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-08-11 11:52+0100, James Hogan: > These patches fix several issues in the management of MIPS KVM TLB > faults: > > 1) kvm_mips_handle_mapped_seg_tlb_fault() misbehaves for virtual address > zero, which can be hit if the guest creates such a mapping and > accesses it in a way unexpected for the commpage (e.g. a CACHE > instruction). > > 2) kvm_mips_handle_mapped_seg_tlb_fault() doesn't range check the gfn, > allowing a high mapping by the guest to overflow the guest_pmap[]. > > 3) kvm_mips_handle_kseg0_tlb_fault() has an off by one in its gfn range > check, which could allow an odd sized guest_pmap[] to be overflowed. > > 4) some callers of kvm_mips_handle_kseg0_tlb_fault() and > kvm_mips_handle_mapped_seg_tlb_fault() don't correctly propagate > errors upwards. > > They're all marked for stable but won't apply cleanly before v4.8-rc1 > due to recent changes. I have backports ready though. Applied, thanks.