From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PART2 PATCH v6 12/12] svm: Implements update_pi_irte hook to setup posted interrupt Date: Fri, 19 Aug 2016 17:04:06 +0200 Message-ID: <20160819150405.GA5282@potion> References: <1471549364-6672-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1471549364-6672-13-git-send-email-Suravee.Suthikulpanit@amd.com> <20160819144907.GB1885@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: joro@8bytes.org, pbonzini@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com To: Suravee Suthikulpanit Return-path: Content-Disposition: inline In-Reply-To: <20160819144907.GB1885@potion> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2016-08-19 16:49+0200, Radim Krčmář: > Minor design note: > To make the usage of "struct amd_ir_data" safer, we could pass "struct > list_head" into irq_set_vcpu_affinity(), instead of returning "struct > amd_ir_data *". > > irq_set_vcpu_affinity() would add "struct amd_ir_data" to the list only > if ir_data was not already in some list and report whether the list > was modified. No, this would not simplify the search. An important point of list_head in amd_ir_data was to let us know the current list.