Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices

Michael S. Tsirkin
2016-08-30T03:49:51Z

On Tue, Aug 30, 2016 at 11:16:25AM +0800, Jason Wang wrote:
>
>
> On 2016年08月30日 10:27, Michael S. Tsirkin wrote:
> > Legacy virtio devices always bypassed an IOMMU, so using them with vfio was
> > never safe.
>
> And it actually won't work since GPA is assumed in the device. So I'm not
> sure this is must since we should get a IOMMU fault in this case.

We won't get an IOMMU fault for legacy systems since they
bypass the IOMMU. Instead guest userspace will get full
access to all of guest memory through the device.

> > This adds a quirk detecting these and disabling VFIO unless the
> > noiommu mode is used. At the moment, this only applies to virtio-pci devices.
> >
> > The patch might make sense on stable as well.
> >
> > Michael S. Tsirkin (2):
> > vfio: report group noiommu status
> > vfio: add virtio pci quirk
> >
> > drivers/vfio/pci/vfio_pci_private.h | 1 +
> > include/linux/vfio.h | 2 +
> > drivers/vfio/pci/vfio_pci.c | 14 ++++
> > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++
> > drivers/vfio/vfio.c | 12 ++++
> > drivers/vfio/pci/Makefile | 1 +
> > 6 files changed, 170 insertions(+)
> > create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org