Re: [PATCH 1/5] arm/arm64: KVM: Don't BUG_ON if IT bits are set in ARM mode

Marc Zyngier
2016-09-01T12:21:23Z

On 01/09/16 12:56, Christoffer Dall wrote:
> On Fri, Aug 19, 2016 at 01:38:11PM +0100, Marc Zyngier wrote:
>> The ARM ARM asserts that having the IT bits set in ARM mode is
>> unpredictable. But should a CPU do that (and still be able to
>> run correctly), we shouldn't kill the system.
>>
>> So let's drop the BUG_ON that checks for this, as it is not
>> very helpful.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> not sure how this relates to the series, but looks fine otherwise:

In the following patch, I'm moving the whole function to be an inline
that will be used in HYP as well. A BUG_ON in HYP is a pretty tasteless
thing to do, so I opted for removing it here.

But your remark on the following patch makes more sense over all. I'll
follow up there.

> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>

Thanks,

M.
--
Jazz is not dead. It just smells funny...