Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

Paolo Bonzini
2016-09-16T12:31:42Z

On 16/09/2016 14:30, Christoffer Dall wrote:
> > > > This patch set allows user space to receive vtimer events as well as mask
> > > > them, so that we can handle all vtimer related interrupt injection from user
> > > > space, enabling us to use architected timer with user space gic emulation.
> > >
> > > I have already voiced my concerns in the past, including face to face,
> > > and I'm going to repeat it: I not keen at all on adding a new userspace
> > > interface that is going to bitrot extremely quickly.
> >
> > You don't have automated tests set up? It's not going to bitrot if you
> > test it, either with kvm-unit-tests or just by smoke-testing Linux.
> > It's _for_ the raspi, but it's not limited to it.
>
> Our automated testing situation is not great, no. Something we're
> looking at, but have resource problems with.

But it's not a good reason to hold back a feature...

Paolo