From: Andrew Jones <drjones@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test
Date: Wed, 21 Sep 2016 10:12:51 +0200 [thread overview]
Message-ID: <20160921081251.4hngwcf2crzlvu3c@hawk.localdomain> (raw)
In-Reply-To: <1474434582-21431-1-git-send-email-peterx@redhat.com>
On Wed, Sep 21, 2016 at 01:09:40PM +0800, Peter Xu wrote:
> 1st patch fixes not eoi()ing in existing deadline timer isr.
>
> 2nd patch adds lvtt test. Please review. Thanks!
>
> v2
> - adding eoi() in LVT timer handler, otherwise continuous interrupt
> will be ignored (found this when testing together with deadline
> timer)
> - better comments for "initial" [Drew]
> - check lvtt_counter==1 in report() [Drew]
> - setting x86/apic timeout to 30s [Drew]
>
> Peter Xu (2):
> x86: apic: eoi() for deadline timer isr
> x86: apic: add LVT timer test
>
> x86/apic.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> x86/unittests.cfg | 1 +
> 2 files changed, 45 insertions(+)
>
> --
> 2.7.4
Both patches look good to me.
Thanks,
drew
next prev parent reply other threads:[~2016-09-21 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 5:09 [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test Peter Xu
2016-09-21 5:09 ` [kvm-unit-tests PATCH v2 1/2] x86: apic: eoi() for deadline timer isr Peter Xu
2016-09-21 5:09 ` [kvm-unit-tests PATCH v2 2/2] x86: apic: add LVT timer test Peter Xu
2016-09-21 8:10 ` Andrew Jones
2016-09-21 8:12 ` Andrew Jones [this message]
2016-09-22 22:41 ` [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921081251.4hngwcf2crzlvu3c@hawk.localdomain \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).