From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: VMX: refactor global page-sized bitmaps Date: Tue, 27 Sep 2016 16:13:07 +0200 Message-ID: <20160927141306.GA26260@potion> References: <20160922231840.26746-1-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbcI0ONK (ORCPT ); Tue, 27 Sep 2016 10:13:10 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-09-23 11:35+0200, Paolo Bonzini: > On 23/09/2016 01:18, Radim Krčmář wrote: >> We've had 10 page-sized bitmaps that were being allocated and freed one >> by one when we could just use a cycle and MSR bitmaps had a lot of >> useless code lying around. >> >> This patch >> * enumerates vmx bitmaps and uses an array to store them >> * replaces vmx_enable_intercept_msr_read_x2apic() with a condition >> * joins vmx_msr_disable_intercept_msr_{read,write}_x2apic() >> * renames x2apic_apicv_inactive msr_bitmaps to x2apic and original >> x2apic bitmaps to x2apic_apicv > > It's almost like this could be split in four patches! :) Seriously, I > like it very much but it's very hard to review. Yeah, sorry, v2 will be split. > Also, while it's a good idea to keep the bitmaps in an array, > vmx_bitmaps[vmread_bitmap] is not very readable. Please make the enum > uppercase, and possibly add > > #define vmread_bitmap (vmx_bitmaps[VMREAD_BITMAP]) This will make it much easier to review, thanks.