From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Alexander Gordeev <agordeev@redhat.com>,
kvm@vger.kernel.org, Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v7 00/13] PCI bus support
Date: Wed, 28 Sep 2016 14:33:09 +0800 [thread overview]
Message-ID: <20160928063309.GC11134@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160922111004.45znovqflj6fgrnr@hawk.localdomain>
On Thu, Sep 22, 2016 at 01:10:04PM +0200, Andrew Jones wrote:
[...]
> I finally had a chance to take a look at this. There's no BAR#4 being
> exposed from pci-testdev. QEMU is adding a default virtio-net-pci device,
> which does have a BAR#4. Adjusting the QEMU env like this
>
> export QEMU="$QEMU -nodefaults"
>
> which removes default devices, allows the new unit test to run and pass.
>
> kvm-unit-tests shouldn't be asserting and dying when it's presented a
> valid virtio-net-pci device though. It should handle the probing
> correctly, or at least just warn that it doesn't know how to, and then
> ignore it. Alex, can you consider what might need to be tweaked in this
> series to do that?
>
> That said, as kvm-unit-tests isn't going to drive non-testdev devices
> anyway, then just removing default devices is a reasonable thing to do
> too. I'll submit a patch adding '-nodefaults -nodefconfig' to the arm
> QEMU command line.
Could I ask what's the status of this series? I see that this is still
not in master (nor did I saw any further works from Alex).
Thanks,
-- peterx
next prev parent reply other threads:[~2016-09-28 6:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 12:07 [kvm-unit-tests PATCH v7 00/13] PCI bus support Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 01/13] pci: Fix coding style in generic PCI files Alexander Gordeev
2016-08-18 11:37 ` Thomas Huth
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 02/13] pci: x86: Rename pci_config_read() to pci_config_readl() Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 03/13] pci: Add 'extern' to public function declarations Alexander Gordeev
2016-08-17 13:49 ` Andrew Jones
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 04/13] pci: x86: Add remaining PCI configuration space accessors Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 05/13] pci: Factor out pci_bar_get() Alexander Gordeev
2016-08-18 11:39 ` Thomas Huth
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 06/13] pci: Rework pci_bar_addr() Alexander Gordeev
2016-09-23 7:14 ` Peter Xu
2016-09-23 8:51 ` Andrew Jones
2016-09-23 8:58 ` Peter Xu
2016-10-12 14:37 ` Alexander Gordeev
2016-10-13 6:40 ` Peter Xu
2016-10-13 14:16 ` Alexander Gordeev
2016-10-14 6:23 ` Peter Xu
2016-10-14 6:55 ` Andrew Jones
2016-10-14 9:09 ` Peter Xu
2016-10-14 12:37 ` Alexander Gordeev
2016-10-19 3:46 ` Peter Xu
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 07/13] pci: Add pci_bar_set_addr() Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 08/13] pci: Add pci_dev_exists() Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 09/13] pci: Add pci_print() Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 10/13] pci: Add generic ECAM host support Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 11/13] arm/arm64: pci: Add PCI bus operation test Alexander Gordeev
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 12/13] pci: Add pci-testdev PCI bus test device Alexander Gordeev
2016-08-17 14:03 ` Andrew Jones
2016-09-23 7:25 ` Peter Xu
2016-09-23 8:55 ` Andrew Jones
2016-10-12 16:54 ` Alexander Gordeev
2016-10-13 6:52 ` Peter Xu
2016-10-13 13:16 ` Alexander Gordeev
2016-10-14 5:01 ` Peter Xu
2016-10-14 7:07 ` Andrew Jones
2016-10-14 9:14 ` Peter Xu
2016-08-17 12:07 ` [kvm-unit-tests PATCH v7 13/13] arm/arm64: pci: Add pci-testdev PCI device operation test Alexander Gordeev
2016-08-17 14:26 ` [kvm-unit-tests PATCH v7 00/13] PCI bus support Andrew Jones
2016-08-23 18:28 ` Alexander Gordeev
2016-09-22 11:10 ` Andrew Jones
2016-09-28 6:33 ` Peter Xu [this message]
2016-10-12 8:00 ` Alexander Gordeev
2016-10-12 10:59 ` Peter Xu
2016-10-12 14:35 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928063309.GC11134@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=agordeev@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).