From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH v3] powerpc: Check whether TM is available before running other tests Date: Wed, 12 Oct 2016 16:49:44 +0200 Message-ID: <20161012144944.GD30525@potion> References: <1475572050-13164-1-git-send-email-thuth@redhat.com> <1475652308.2070.2.camel@gmail.com> <44839565-1783-02f7-8157-53894d527141@redhat.com> <0eeb8d4a-a01f-6d9e-ec12-7b8eef6204b5@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Huth , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932765AbcJLOtu (ORCPT ); Wed, 12 Oct 2016 10:49:50 -0400 Content-Disposition: inline In-Reply-To: <0eeb8d4a-a01f-6d9e-ec12-7b8eef6204b5@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-10-12 10:19+0200, Paolo Bonzini: > On 12/10/2016 10:04, Thomas Huth wrote: >> On 05.10.2016 09:25, Suraj Jitindar Singh wrote: >>> On Tue, 2016-10-04 at 11:07 +0200, Thomas Huth wrote: >>>> Transactional memory is currently only supported on KVM-HV, and >>>> not yet on KVM-PR. So it's better to check the device tree first >>>> and fail gracefully if it is not available. >>>> >>>> Reviewed-by: Laurent Vivier >>>> Reviewed-by: Andrew Jones >>>> Signed-off-by: Thomas Huth >>> Thanks for sending a v3. >>> >>> Reviewed-by: Suraj Jitindar Singh >>>> --- >>>> v3: >>>> - Removed unnecessary check for "plen >= 26" in cpu_has_tm() >>>> >>>> v2: >>>> - Reworked the check for the "ibm,pa-features" and added a comment >>>> - Use a dedicated variable "has_tm" instead of "i" in main() >>>> >>>> powerpc/tm.c | 43 ++++++++++++++++++++++++++++++++++++++++++- >>>> 1 file changed, 42 insertions(+), 1 deletion(-) >> >> Radim, Paolo, >> >> I think this patch is now ready to go ... could you please pick it up? >> (or shall I send a pull request for it?) > > Pull requests are always welcome, at least by me. :) Seconded. I think cooperation will be smoother when using pull requests ... I didn't notice that the ball was on me this time. Throwing it back for a pull request.