From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v8 4/6] docs: Add Documentation for Mediated devices Date: Thu, 13 Oct 2016 22:22:26 -0600 Message-ID: <20161013222226.0bdbcdf3@t450s.home> References: <1476131317-358-1-git-send-email-kwankhede@nvidia.com> <1476131317-358-5-git-send-email-kwankhede@nvidia.com> <20161011141411.GH14917@redhat.com> <08c939a3-c78e-a457-1978-794ffb50ee2c@nvidia.com> <6814afb2-3e39-f1c9-8944-489391e948e2@nvidia.com> <20161012095955.192affc5@t450s.home> <20161012154457.5a05b4fb@t450s.home> <6d74aedb-881d-0b1b-90ff-aedea7f79156@nvidia.com> <20161013083607.2357fe5f@t450s.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Song, Jike" , "kvm@vger.kernel.org" , "Tian, Kevin" , "qemu-devel@nongnu.org" , "cjia@nvidia.com" , "kraxel@redhat.com" , Laine Stump , "pbonzini@redhat.com" , "bjsdjshi@linux.vnet.ibm.com" To: Kirti Wankhede Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On Fri, 14 Oct 2016 09:01:01 +0530 Kirti Wankhede wrote: > On 10/13/2016 8:06 PM, Alex Williamson wrote: > > On Thu, 13 Oct 2016 14:52:09 +0530 > > Kirti Wankhede wrote: > > > >> On 10/13/2016 3:14 AM, Alex Williamson wrote: > >>> Under the device we have "mtty2", shouldn't that be > >>> "mdev_supported_type", which then links to mtty2? Otherwise a user > >>> needs to decode from the link what this attribute is. > >>> > >> > >> I thought it should show type, so that by looking at 'ls' output user > >> should be able to find type_id. > > > > The type_id should be shown by actually reading the link, not by the > > link name itself, the same way that the iommu_group link for a device > > isn't the group number, it links to the group number but uses a > > standard link name. > > > > Ok. I'll rename the link name to 'mdev_supported_type' Hmm, if we have a device, then clearly it's a supported type, we can probably reduce this to 'mdev_type'. Sorry for not catching that. BTW, please include the linux-kernel mailing list on the CC in your next posting. Thanks, Alex