From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [kvm-unit-tests PATCH v7 12/13] pci: Add pci-testdev PCI bus test device Date: Fri, 14 Oct 2016 17:14:41 +0800 Message-ID: <20161014091441.GC31091@pxdev.xzpeter.org> References: <15b9e7ffcf6f978c58e44e45502331949d61d19f.1471434672.git.agordeev@redhat.com> <20160923072542.GC15411@pxdev.xzpeter.org> <20161012165428.GB31167@dhcp-27-118.brq.redhat.com> <20161013065249.GD21663@pxdev.xzpeter.org> <20161013131648.GD30384@agordeev.lab.eng.brq.redhat.com> <20161014050148.GE21663@pxdev.xzpeter.org> <20161014070707.mxfu7445fc5welqx@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Alexander Gordeev , kvm@vger.kernel.org, Thomas Huth To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49710 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbcJNJOr (ORCPT ); Fri, 14 Oct 2016 05:14:47 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 510303D945 for ; Fri, 14 Oct 2016 09:14:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161014070707.mxfu7445fc5welqx@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Oct 14, 2016 at 09:07:07AM +0200, Andrew Jones wrote: > On Fri, Oct 14, 2016 at 01:01:48PM +0800, Peter Xu wrote: > > On Thu, Oct 13, 2016 at 03:16:49PM +0200, Alexander Gordeev wrote: > > > On Thu, Oct 13, 2016 at 02:52:49PM +0800, Peter Xu wrote: > > > > On Wed, Oct 12, 2016 at 06:54:28PM +0200, Alexander Gordeev wrote: > > > > > On Fri, Sep 23, 2016 at 03:25:42PM +0800, Peter Xu wrote: > > > > > > > + width = ops->io_readb(&test->width); > > > > > > > + if (width != 1 && width != 2 && width != 4) > > > > > > > + return false; > > > > > > > > > > > > IIUC we only have 1? > > > > > > > > > > I guess it boils what *have* does mean here. > > > > > > > > > > pci-testdev protocol allows it to be any, but hw/misc/pci-testdev.c > > > > > implements just 1 (yet?). > > > > > > > > Do we have other possible implementations for pci-testdev protocol? > > > > > > I typed answer twice, but realized I do not get the question. :) > > > Could you paraphrase, please? > > > > Sorry for not being clear. I am just wondering whether there is other > > implementation for pci-testdev besides the one in QEMU. It looks like > > a special device to test QEMU only. > > Yes. pci-testdev (most likely) has never been implemented anywhere other > than in QEMU. It was written specifically for kvm-unit-tests. See > > http://www.linux-kvm.org/page/KVM-unit-tests#Testdevs > > for a synopsis of all testdevs. Please feel free to add more details to > the pci-testdev section. Feel free to help maintain the document in any > other ways too, of course :-) Thanks, Drew. I am trying to use edu device for testing Intel IOMMU. I'll try to post RFC patches first though. When needed, I can update the document for edu device (though I still don't know how to do that). -- peterx