From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: invtsc + migration + TSC scaling
Date: Tue, 18 Oct 2016 15:48:46 +0200
Message-ID: <20161018134846.GB3492@potion>
References: <20161014212031.GQ3275@thinpad.lan.raisama.net>
 <20161017094708.GB31691@amt.cnet>
 <20161017145008.GA2307@potion>
 <72b8c6b3-f08a-735a-e283-99d0195dcf7d@redhat.com>
 <20161017211101.GD3275@thinpad.lan.raisama.net>
 <20161017235846.GA22657@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Eduardo Habkost <ehabkost@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org,
        kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:33384 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1760223AbcJRNsu (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 18 Oct 2016 09:48:50 -0400
Content-Disposition: inline
In-Reply-To: <20161017235846.GA22657@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-10-17 21:58-0200, Marcelo Tosatti:
> On Mon, Oct 17, 2016 at 07:11:01PM -0200, Eduardo Habkost wrote:
>> On Mon, Oct 17, 2016 at 06:24:38PM +0200, Paolo Bonzini wrote:
>> > On 17/10/2016 16:50, Radim Krčmář wrote:
>> > > 2016-10-17 07:47-0200, Marcelo Tosatti:
>> [...]
>> > >> since Linux guests use kvmclock and Windows guests use Hyper-V
>> > >> enlightenment, it should be fine to disable 2).
>> > 
>> > ... and 1 too.
>> > 
>> > We should also blacklist the TSC deadline timer when invtsc is not
>> > available.
> 
> Actually, a nicer fix would be to check the different 
> frequencies and scale the deadline relative to the difference. 

I think that KVM can already be configured to do that.

Paolo, we hit that TSC deadline bug bacause QEMU doesn't set the TSC
frequency if it would result in software scaling (which needs to update
guest TSC and kvmclock on every entry)?

Thanks.

(I just noticed a minor bug: KVM doesn't use hardware scaling when the
 TSC frequency delta is small.)

> This would take care of both patched and non-patched guests.
> 
> On a related note, what was the goal of Radim's paravirtual deadline
> TSC timer?

It's be paravirtual kvmclock timer -- just giving the deadline in other
another time frame.  It won't confuse OS that expect the deadline timer
to behave like it should. :)