Re: [kvm-unit-tests PATCH 02/14] x86: smp: allow multiple init for smp setup

["Radim Krčmář" <rkrcmar@redhat.com>]

2016-10-14 20:40+0800, Peter Xu:
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  lib/x86/smp.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/x86/smp.c b/lib/x86/smp.c
> index 1eb49f2..bb74087 100644
> --- a/lib/x86/smp.c
> +++ b/lib/x86/smp.c
> @@ -111,8 +111,13 @@ void on_cpu_async(int cpu, void (*function)(void *data), void *data)
>  void smp_init(void)
>  {
>      int i;
> +    bool smp_inited = false;

Missing "static".

The first two patches are just for sanity and not needed in the series?

>      void ipi_entry(void);
>  
> +    if (smp_inited) {
> +        return;
> +    }
> +
>      _cpu_count = fwcfg_get_nb_cpus();
>  
>      setup_idt();
> @@ -122,4 +127,5 @@ void smp_init(void)
>      for (i = 1; i < cpu_count(); ++i)
>          on_cpu(i, setup_smp_id, 0);
>  
> +    smp_inited = true;
>  }
> -- 
> 2.7.4
>