Re: [kvm-unit-tests PATCH 02/14] x86: smp: allow multiple init for smp setup

[Peter Xu <peterx@redhat.com>]

On Thu, Oct 20, 2016 at 10:20:30AM +0200, Andrew Jones wrote:
> On Fri, Oct 14, 2016 at 08:40:40PM +0800, Peter Xu wrote:
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  lib/x86/smp.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/lib/x86/smp.c b/lib/x86/smp.c
> > index 1eb49f2..bb74087 100644
> > --- a/lib/x86/smp.c
> > +++ b/lib/x86/smp.c
> > @@ -111,8 +111,13 @@ void on_cpu_async(int cpu, void (*function)(void *data), void *data)
> >  void smp_init(void)
> >  {
> >      int i;
> > +    bool smp_inited = false;
> >      void ipi_entry(void);
> >  
> > +    if (smp_inited) {
> > +        return;
> > +    }
> > +
> >      _cpu_count = fwcfg_get_nb_cpus();
> >  
> >      setup_idt();
> > @@ -122,4 +127,5 @@ void smp_init(void)
> >      for (i = 1; i < cpu_count(); ++i)
> >          on_cpu(i, setup_smp_id, 0);
> >  
> > +    smp_inited = true;
> >  }
> > -- 
> > 2.7.4
> 
> Same comment as last patch. How about
> 
>  assert(!_cpu_count)

Will fix. Thanks!

-- peterx