From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: MIPS: Add missing uaccess.h include Date: Thu, 20 Oct 2016 15:10:54 +0200 Message-ID: <20161020131054.GF8573@potion> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-mips@linux-mips.org, Paolo Bonzini , Ralf Baechle , kvm@vger.kernel.org To: James Hogan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42982 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934085AbcJTNK6 (ORCPT ); Thu, 20 Oct 2016 09:10:58 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: 2016-10-19 00:45+0100, James Hogan: > MIPS KVM uses user memory accessors but mips.c doesn't directly include > uaccess.h, so include it now. > > This wasn't too much of a problem before v4.9-rc1 as asm/module.h > included asm/uaccess.h, however since commit 29abfbd9cbba ("mips: > separate extable.h, switch module.h to it") this is no longer the case. > > This resulted in build failures when trace points were disabled, as > trace/define_trace.h includes trace/trace_events.h only ifdef > TRACEPOINTS_ENABLED, which goes on to include asm/uaccess.h via a couple > of other headers. > > Fixes: 29abfbd9cbba ("mips: separate extable.h, switch module.h to it") > Signed-off-by: James Hogan > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Cc: kvm@vger.kernel.org > --- We'd like to have this patch in 4.9-rc2 and I see it in kvm-mips/next. Would you prefer to send a pull request? (I can apply it directly just as well.) Thanks.