Re: [PATCH] KVM: MIPS: Add missing uaccess.h include

[James Hogan <james.hogan@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Hi Radim,

On Thu, Oct 20, 2016 at 03:10:54PM +0200, Radim Krčmář wrote:
> 2016-10-19 00:45+0100, James Hogan:
> > MIPS KVM uses user memory accessors but mips.c doesn't directly include
> > uaccess.h, so include it now.
> > 
> > This wasn't too much of a problem before v4.9-rc1 as asm/module.h
> > included asm/uaccess.h, however since commit 29abfbd9cbba ("mips:
> > separate extable.h, switch module.h to it") this is no longer the case.
> > 
> > This resulted in build failures when trace points were disabled, as
> > trace/define_trace.h includes trace/trace_events.h only ifdef
> > TRACEPOINTS_ENABLED, which goes on to include asm/uaccess.h via a couple
> > of other headers.
> > 
> > Fixes: 29abfbd9cbba ("mips: separate extable.h, switch module.h to it")
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > Cc: kvm@vger.kernel.org
> > ---
> 
> We'd like to have this patch in 4.9-rc2 and I see it in kvm-mips/next.
> Would you prefer to send a pull request?

Yes, I've applied it to my next branch and was going to send a pull
request this afternoon.

BTW, generally speaking do you always prefer pull requests to have the
patches sent in reply to it, or only if they haven't already been posted
for review?

> (I can apply it directly just as well.)

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]