From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX
 preemption timer support
Date: Thu, 20 Oct 2016 20:10:33 +0200
Message-ID: <20161020181033.GA6375@potion>
References: <1476690302-22158-1-git-send-email-wanpeng.li@hotmail.com>
 <1476690302-22158-6-git-send-email-wanpeng.li@hotmail.com>
 <20161019192826.GA8573@potion>
 <CANRm+CwhSXXAtbPn_etTg0_6ik7_5Tte7SRA4L7TJhoSRbyF7w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Yunhong Jiang <yunhong.jiang@intel.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
To: Wanpeng Li <kernellwp@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CANRm+CwhSXXAtbPn_etTg0_6ik7_5Tte7SRA4L7TJhoSRbyF7w@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

2016-10-20 06:57+0800, Wanpeng Li:
> 2016-10-20 3:28 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
>> I think it would be better to add a function to advance the periodic
>> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn().
>>
>> The function can be simpler than set_target_expiration(), because it
>> just adds the period to an existing timer.  Periodic timer will also be
>> better then, because the period will not depend on KVM's latency when
>> rearming.
> 
> Good point, what's the function name do you like? How about
> advance_target_expiration()?

Sounds good, I'd just slap periodic somewhere,
advance_periodic_target_expiration()?