From: Will Deacon <will.deacon@arm.com>
To: riku.voipio@linaro.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] kvmtool: Makefile: disable PIE build for bios and pre_init
Date: Wed, 26 Oct 2016 18:32:40 +0100 [thread overview]
Message-ID: <20161026173240.GF15216@arm.com> (raw)
In-Reply-To: <20161024105853.20083-1-riku.voipio@linaro.org>
On Mon, Oct 24, 2016 at 01:58:53PM +0300, riku.voipio@linaro.org wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Latest Debian and Ubuntu GCC default to PIE code. Disable
> PIE for bios and pre_init. Since the flag -no-pie is not
> available on older GCC's, make use of flag only if the
> option is available.
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837545
> ---
> Makefile | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1f0196f..0d8b66d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -284,7 +284,7 @@ ifeq ($(call try-build,$(SOURCE_STATIC),$(CFLAGS),$(LDFLAGS) -static),y)
> GUEST_INIT := guest/init
> GUEST_OBJS = guest/guest_init.o
> ifeq ($(ARCH_PRE_INIT),)
> - GUEST_INIT_FLAGS += -static
> + GUEST_INIT_FLAGS += -static $(PIE_FLAGS)
> else
> CFLAGS += -DCONFIG_GUEST_PRE_INIT
> GUEST_INIT_FLAGS += -DCONFIG_GUEST_PRE_INIT
> @@ -307,6 +307,10 @@ ifeq (y,$(ARCH_WANT_LIBFDT))
> endif
> endif
>
> +ifeq ($(call try-build,$(SOURCE_HELLO),$(CFLAGS),-no-pie),y)
> + PIE_FLAGS += -no-pie
> +endif
> +
> ifneq ($(NOTFOUND),)
> $(warning Skipping optional libraries: $(NOTFOUND))
> endif
> @@ -388,7 +392,7 @@ $(PROGRAM_ALIAS): $(PROGRAM)
> ifneq ($(ARCH_PRE_INIT),)
> $(GUEST_PRE_INIT): $(ARCH_PRE_INIT)
> $(E) " LINK " $@
> - $(Q) $(CC) -s -nostdlib $(ARCH_PRE_INIT) -o $@
> + $(Q) $(CC) -s $(PIE_FLAGS) -nostdlib $(ARCH_PRE_INIT) -o $@
> $(Q) $(LD) -r -b binary -o guest/guest_pre_init.o $(GUEST_PRE_INIT)
> endif
>
> @@ -435,6 +439,8 @@ BIOS_CFLAGS += -march=i386
> BIOS_CFLAGS += -mregparm=3
>
> BIOS_CFLAGS += -fno-stack-protector
> +BIOS_CFLAGS += $(PIE-FLAGS)
Shouldn't that be an underscore? Did you test this?
Will
next prev parent reply other threads:[~2016-10-26 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:58 [PATCH] kvmtool: Makefile: disable PIE build for bios and pre_init riku.voipio
2016-10-26 17:32 ` Will Deacon [this message]
2016-11-04 13:10 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026173240.GF15216@arm.com \
--to=will.deacon@arm.com \
--cc=kvm@vger.kernel.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).