Re: [PATCH 8/8] nvdimm acpi: use common macros instead of magic names

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

On Sat, Oct 29, 2016 at 12:11:56AM +0800, Xiao Guangrong wrote:
>      /*
>       * DSM notifier:
> -     * NTFI: write the address of DSM memory and notify QEMU to emulate
> -     *       the access.
> +     * NVDIMM_DSM_NOTIFY: write the address of DSM memory and notify QEMU to
> +     *                    emulate the access.

Did you mean to search-replace this instance of "NTFI"?

>      /*
>       * DSM input:
> -     * HDLE: store device's handle, it's zero if the _DSM call happens
> -     *       on NVDIMM Root Device.
> -     * REVS: store the Arg1 of _DSM call.
> -     * FUNC: store the Arg2 of _DSM call.
> -     * FARG: store the Arg3 of _DSM call which is a Package containing
> -     *       function-specific arguments.
> +     * NVDIMM_DSM_HANDLE: store device's handle, it's zero if the _DSM call
> +     *                    happens on NVDIMM Root Device.
> +     * NVDIMM_DSM_REVISION: store the Arg1 of _DSM call.
> +     * NVDIMM_DSM_FUNCTION: store the Arg2 of _DSM call.
> +     * NVDIMM_DSM_ARG3: store the Arg3 of _DSM call which is a Package
> +     *                  containing function-specific arguments.

Did you mean to search-replace these names?  I think it makes sense to
use the literal ACPI names instead of the macro names in documentation.

>      /*
>       * DSM output:
> -     * RLEN: the size of the buffer filled by QEMU.
> -     * ODAT: the buffer QEMU uses to store the result.
> +     * NVDIMM_DSM_OUT_BUF_SIZE: the size of the buffer filled by QEMU.
> +     * NVDIMM_DSM_OUT_BUF: the buffer QEMU uses to store the result.

Same here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]