From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH 2/3] KVM: arm/arm64: Add ARM arch timer interrupts ABI Date: Tue, 1 Nov 2016 16:32:32 +0100 Message-ID: <20161101153232.GD13677@cbox> References: <20160927190806.22988-1-christoffer.dall@linaro.org> <20160927190806.22988-3-christoffer.dall@linaro.org> <20161101145019.GB13677@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Marc Zyngier , Paolo Bonzini , "kvmarm@lists.cs.columbia.edu" , arm-mail-list To: Peter Maydell Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Tue, Nov 01, 2016 at 02:54:11PM +0000, Peter Maydell wrote: > On 1 November 2016 at 14:50, Christoffer Dall > wrote: > > On Tue, Nov 01, 2016 at 11:26:54AM +0000, Peter Maydell wrote: > >> Possible current and future outbound interrupt lines (some of these > >> would only show up in some unlikely or lots-of-implementation-needed > >> cases, I'm just trying to produce an exhaustive list): > >> * virtual timer > >> * physical timer > >> * hyp timer (nested virtualization case) > >> * secure timer (unlikely but maybe if EL3 is ever supported inside a VM) > >> * gic maintenance interrupt (nested virt again) > >> * PMU interrupt > > > > Thanks for the list, that's good to have around for the future. > > > > There's also the potential of the EL2 virtual timer for nested VHE > > support, right? > > That's the one I meant by "hyp timer". > there's the hyp timer, and then there's the ARMv8.1 virtual hyp timer. > >> The kernel doesn't know which interrupt number these would be wired > >> up to, so they're all just arbitrary outputs, and you could put them > >> in one field or split them up into multiple fields, it doesn't make > >> much difference. > >> > > > > So if we keep this we're kind of suggesting that we'll have a field per > > device type later on. Since this is a u8 and we are talking about up 5 > > 5 timers already, > > 4. > virtual physical hyp virtual hyp secure Am I missing something? -Christoffer