From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [PATCH v4 2/3] nvdimm acpi: introduce _FIT
Date: Thu, 3 Nov 2016 09:53:53 +0000
Message-ID: <20161103095353.GA5154@stefanha-x1.localdomain>
References: <1478145090-11987-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o"
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
        mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com,
        rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com,
        kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f65.google.com ([74.125.82.65]:32807 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752466AbcKCJx5 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 3 Nov 2016 05:53:57 -0400
Received: by mail-wm0-f65.google.com with SMTP id u144so7103914wmu.0
        for <kvm@vger.kernel.org>; Thu, 03 Nov 2016 02:53:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1478145090-11987-3-git-send-email-guangrong.xiao@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


--IS0zKkzwUGydFO0o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote:
> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwad=
dr dsm_mem_addr)
>      cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out));
>  }
> =20
> +#define NVDIMM_DSM_RET_STATUS_SUCCESS        0 /* Success */
> +#define NVDIMM_DSM_RET_STATUS_UNSUPPORT      1 /* Not Supported */
> +#define NVDIMM_DSM_RET_STATUS_INVALID        3 /* Invalid Input Paramete=
rs */

Not worth changing but please make each logical change a separate patch
in the future.  This patch is cluttered with NVDIMM_DSM_RET_STATUS_
constant renaming.  It's easier to review, bisect, and backport when
structured as separate patches.

--IS0zKkzwUGydFO0o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJYGwkxAAoJEJykq7OBq3PIAVgH/jNRx41OcpsDIg/8d3FJkjTu
Es5MWbkkoBvNwy/au1FZ/pj53YRzG09+rZG8WfVE7bK2iVkbRo+6q0CHi162+1QD
E2wgKaz74/KtAuMbFIvfmdrU0MBm0DcVmCQB8v60I1whjya/6HnbuLVAIBdK3Khh
yzJ9b5ZcBosiy5gFPLKenXLYm9n9/fVyjw8ArICbYS716bEwF0xhOxEMyuz3L7FE
SgSMM23Wop3LntDEpkFGV3iLNkm7SLjnghT/xe0l06XwcqFoiNOyNUuKfTcNr/Fz
YAdEFsqFnBz1VTV4FX5p8e4bp8cgTFs3E8e0ADQUTnHyrUmXTBu/S9IO6tuEwyY=
=Zx2w
-----END PGP SIGNATURE-----

--IS0zKkzwUGydFO0o--