From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v9 03/12] pci: Add 'extern' to public
 function declarations
Date: Fri, 4 Nov 2016 09:18:12 +0100
Message-ID: <20161104081812.32fdtxjsgnu4gqjt@hawk.localdomain>
References: <cover.1478189002.git.agordeev@redhat.com>
 <24c5c29c3bbd3fed9091efa8586c90068037f168.1478189002.git.agordeev@redhat.com>
 <20161103203023.GA22260@infradead.org>
 <38d009b0-a8db-85fc-65ff-7bf58f31d2c1@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
        Alexander Gordeev <agordeev@redhat.com>, kvm@vger.kernel.org,
        Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32942 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752452AbcKDISR (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 4 Nov 2016 04:18:17 -0400
Content-Disposition: inline
In-Reply-To: <38d009b0-a8db-85fc-65ff-7bf58f31d2c1@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Nov 04, 2016 at 08:36:05AM +0100, Thomas Huth wrote:
> On 03.11.2016 21:30, Christoph Hellwig wrote:
> > Why?  The extern keyword for function prototypes is a no-op.
> 
> It's used in many of the kvm-unit-test header files already, so I guess
> the code looks a little bit more consistent this way.

Yeah, it's a bit of an annoying, historic trait of kvm-unit-tests.
Until we do a big extern removing patch to clean those up, then I
prefer we keep things consistent.

Thanks,
drew