Re: [kvm-unit-tests PATCH v10 10/12] pci: Add generic ECAM host support

[Alexander Gordeev <agordeev@redhat.com>]

On Sat, Nov 05, 2016 at 06:20:06PM +0100, Alexander Gordeev wrote:
> +bool pci_probe(void)
> +{
> +	pcidevaddr_t dev;
> +	u8 header;
> +	u32 cmd;
> +	int i;
> +
> +	assert(!pci_host_bridge);
> +	pci_host_bridge = pci_dt_probe();
> +	if (!pci_host_bridge)
> +		return false;
> +
> +	for (dev = 0; dev < 256; dev++) {
> +		if (!pci_dev_exists(dev))
> +			continue;
> +
> +		/* We are only interested in normal PCI devices */
> +		header = pci_config_readb(dev, PCI_HEADER_TYPE);
> +		if ((header & PCI_HEADER_TYPE_MASK) != PCI_HEADER_TYPE_NORMAL)
> +			continue;
> +
> +		cmd = PCI_COMMAND_SERR;

Sigh. Please, ignore this patch.
I forgot to add PCI_COMMAND_PARITY here, as intended.

> +		for (i = 0; i < 6; i++) {
> +			u64 addr;
> +
> +			if (pci_alloc_resource(dev, i, &addr)) {
> +				pci_bar_set_addr(dev, i, addr);
> +
> +				if (pci_bar_is_memory(dev, i))
> +					cmd |= PCI_COMMAND_MEMORY;
> +				else
> +					cmd |= PCI_COMMAND_IO;
> +			}
> +
> +			if (pci_bar_is64(dev, i))
> +				i++;
> +		}
> +
> +		pci_config_writel(dev, PCI_COMMAND, cmd);
> +	}
> +
> +	return true;
> +}