From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [kvm-unit-tests PATCH v9 10/12] pci: Add generic ECAM host support Date: Mon, 7 Nov 2016 23:43:20 +0800 Message-ID: <20161107154320.GA3719@pxdev.xzpeter.org> References: <20161104143352.gakhitj32hoojsfh@kamzik.brq.redhat.com> <20161104170741.4wpcvde6eq7uqcyk@kamzik.brq.redhat.com> <20161105172543.GC10472@agordeev.lab.eng.brq.redhat.com> <20161107084439.l7cpcomczhnep3yn@kamzik.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Alexander Gordeev , kvm@vger.kernel.org, Thomas Huth To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50100 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753307AbcKGPnW (ORCPT ); Mon, 7 Nov 2016 10:43:22 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C345B61E48 for ; Mon, 7 Nov 2016 15:43:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161107084439.l7cpcomczhnep3yn@kamzik.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Nov 07, 2016 at 09:44:39AM +0100, Andrew Jones wrote: > On Sat, Nov 05, 2016 at 06:25:44PM +0100, Alexander Gordeev wrote: > > > Another note on this PCI_COMMAND write. Why is it safe [correct?] to > > > use writel? This is a 16-bit register according to the comment in > > > lib/linux/pci_regs.h. Don't we need to introduce a pci_config_writew > > > and use that? If so, then you should grab Peter Xu's patch that > > > introduces pci_config_writeb/w. > > > > You are right, this is cleanly a bug. > > > > However, I can not put Peter's patch neither before nor after mine, > > since pci_config_write*() are both introduced and used in this patch. > > As Peter's patch needs a refreshment anyway (see my comment on it) > > I will add pci_config_writew() to this patch. Hope, that works for > > everyone. > > It's a trivial patch, so I guess Peter would be fine with you just > doing it however it works best for this series, and then he'll drop > his patch. Yeah, please. I'll drop mine. Thanks, -- peterx