From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 10/17] pci: provide pci_set_master()
Date: Tue, 8 Nov 2016 01:35:02 +0800
Message-ID: <20161107173502.GI3719@pxdev.xzpeter.org>
References: <1477468040-21034-1-git-send-email-peterx@redhat.com>
 <1477468040-21034-11-git-send-email-peterx@redhat.com>
 <20161104170456.g2kamipgo26kziwr@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:48572 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753614AbcKGRgZ (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 7 Nov 2016 12:36:25 -0500
Content-Disposition: inline
In-Reply-To: <20161104170456.g2kamipgo26kziwr@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Nov 04, 2016 at 06:04:56PM +0100, Andrew Jones wrote:
> On Wed, Oct 26, 2016 at 03:47:13PM +0800, Peter Xu wrote:
> > We need to call this whenever we want to do DMA with a device.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  lib/pci.c | 7 +++++++
> >  lib/pci.h | 1 +
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/lib/pci.c b/lib/pci.c
> > index 95a6581..1495f61 100644
> > --- a/lib/pci.c
> > +++ b/lib/pci.c
> > @@ -7,6 +7,13 @@
> >  #include "pci.h"
> >  #include "asm/pci.h"
> >  
> > +void pci_set_master(struct pci_dev *dev, int master)
> 
> Why take pci_dev instead of just the devid/bdf here?
> What is the 'master' argument (which is unused and at least
> needs an __unused to compile) here for?

I think both works for me here, but when this happens, IMHO pci_dev
struct is prefered, since as long as the caller has one *dev pointer
(I think if we introduce pci_dev, people should always keep one object
for each PCI device they manipulate in kvm-unit-tests), I would just
let people to pass in "dev" rather than "dev->pci_bdf", since it's
shorter for typing, and also it avoids referencing internal fields.

Regarding to the "master" variable... Oops, I just missed that. What I
want to do is:

	if (master)
		val |= PCI_COMMAND_MASTER;
	else
		val &= ~PCI_COMMAND_MASTER;

Thanks for pointing out. Will fix.

-- peterx