From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 13/17] pci: edu: introduce pci-edu helpers
Date: Tue, 8 Nov 2016 01:41:24 +0800
Message-ID: <20161107174124.GJ3719@pxdev.xzpeter.org>
References: <1477468040-21034-1-git-send-email-peterx@redhat.com>
 <1477468040-21034-14-git-send-email-peterx@redhat.com>
 <20161104171856.rqfaqlndtk2pzubp@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43020 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932648AbcKGRl0 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 7 Nov 2016 12:41:26 -0500
Content-Disposition: inline
In-Reply-To: <20161104171856.rqfaqlndtk2pzubp@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Nov 04, 2016 at 06:18:56PM +0100, Andrew Jones wrote:

[...]

> > +static inline uint32_t edu_reg_read(struct pci_edu_dev *dev, int reg)
> 
> please add the 'l' this read function name

[...]

> > +static inline void edu_reg_write(struct pci_edu_dev *dev, int reg,
> > +				 uint32_t val)
> 
> please add the 'l'

Fixing both. 

> Otherwise
> 
> Reviewed-by: Andrew Jones <drjones@redhat.com>

Thanks,

-- peterx