From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [QEMU PATCH v2] kvmclock: advance clock by time window between vm_stop and pre_save Date: Tue, 8 Nov 2016 11:32:33 -0200 Message-ID: <20161108133230.GA3660@amt.cnet> References: <20161104094322.GA16930@amt.cnet> <20161104165933.GA3027@amt.cnet> <20161107154610.GG2054@work-vm> <20161107194058.GB28327@amt.cnet> <20161107200349.GC1155@work-vm> <20161108000609.GA3689@amt.cnet> <20161108102255.GC2042@work-vm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Juan Quintela , Eduardo Habkost To: "Dr. David Alan Gilbert" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48432 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbcKHTEZ (ORCPT ); Tue, 8 Nov 2016 14:04:25 -0500 Content-Disposition: inline In-Reply-To: <20161108102255.GC2042@work-vm> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Nov 08, 2016 at 10:22:56AM +0000, Dr. David Alan Gilbert wrote: > * Marcelo Tosatti (mtosatti@redhat.com) wrote: > > On Mon, Nov 07, 2016 at 08:03:50PM +0000, Dr. David Alan Gilbert wrote: > > > * Marcelo Tosatti (mtosatti@redhat.com) wrote: > > > > On Mon, Nov 07, 2016 at 03:46:11PM +0000, Dr. David Alan Gilbert wrote: > > > > > * Marcelo Tosatti (mtosatti@redhat.com) wrote: > > > > > > This patch, relative to pre-copy migration codepath, > > > > > > measures the time between vm_stop() and pre_save(), > > > > > > which includes copying the remaining RAM to destination, > > > > > > and advances the clock by that amount. > > > > > > > > > > > > In a VM with 5 seconds downtime, this reduces the guest > > > > > > clock difference on destination from 5s to 0.2s. > > > > > > > > > > > > Tested with Linux and Windows 2012 R2 guests with -cpu XXX,+hv-time. > > > > > > > > > > One thing that bothers me is that it's only this clock that's > > > > > getting corrected; doesn't it cause things to get upset when > > > > > one clock moves and the others dont? > > > > > > > > If you are correlating the clocks, then yes. > > > > > > > > Older Linux guests get upset (marking the TSC clocksource unstable > > > > because the watchdog checks TSC vs kvmclock), but there is a workaround for it > > > > in newer guests > > > > (kvmclock interface to notify watchdog to not complain). > > > > > > > > Note marking TSC clocksource unstable on older guests is harmless > > > > because kvmclock is the standard clocksource. > > > > > > > > For Windows guests, i don't know that Windows correlates between different > > > > clocks. > > > > > > > > That is, there is relative control as to which software reads kvmclock > > > > or Windows TIMER MSR, so i don't see the need to advance every clock > > > > exposed. > > > > > > > > > Shouldn't the pause delay be recorded somewhere architecturally > > > > > independent and then be a thing that kvm-clock happens to use and > > > > > other clocks might as well? > > > > > > > > In theory, yes. In practice, i don't see the need for this... > > > > > > It seems unlikely to me that x86 is the only one that will want > > > to do something similar. > > > > Can't they copy what kvmclock is doing today? > > We shouldn't have copies of code all over should we? > > Dave Fine i'll add a notifier.