From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 17/17] x86/unittests: add intel-iommu test
Date: Tue, 8 Nov 2016 10:57:27 -0500
Message-ID: <20161108155727.GH2793@pxdev.xzpeter.org>
References: <1477468040-21034-1-git-send-email-peterx@redhat.com>
 <1477468040-21034-18-git-send-email-peterx@redhat.com>
 <20161104174623.2ura5xy6xe5hfpmd@kamzik.brq.redhat.com>
 <20161107180627.GM3719@pxdev.xzpeter.org>
 <20161108103955.vrfi76as2xyihkbq@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60834 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751099AbcKHP5a (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 8 Nov 2016 10:57:30 -0500
Content-Disposition: inline
In-Reply-To: <20161108103955.vrfi76as2xyihkbq@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Nov 08, 2016 at 11:39:55AM +0100, Andrew Jones wrote:

[...]

> > For this test, the latest command line should be:
> > 
> >   -M q35,kernel-irqchip=split -device intel-iommu,intremap=on -device edu
> > 
> > However it will fail if kernel version <4.7 (without x2apic supported
> > KVM). No chance for a report_skip().
> > 
> > I can use eim=off to avoid that check, however, if with "eim=off", we have:
> > 
> >   -M q35,kernel-irqchip=split -device intel-iommu,intremap=on,eim=off -device edu
> > 
> > It requires QEMU to be latest (>2.8). Otherwise QEMU will report "eim
> > property not found" and we lost chance to report as well.
> > 
> > So, I just chose to use pc-q35-2.7 here. Not sure whether this is a
> > good idea.
> 
> I think we just shouldn't care. Either this test is run on the latest
> kernel and qemu, or it will fail. Hopefully something ends up in test.log
> that indicates it failed due to an old kernel or old qemu. Old qemu is
> clear from the "eim property not found"

I see. Then let me make it simpler. I'll use q35 directly with eim=off.

> 
> Alternatively we can build support into runtime to capture kernel, qemu
> versions and compare them against new unittests.cfg {kvm,qemu}_minver
> fields. That would be a different series though, and will require
> extending mkstandalone as well. Feel free to add it to your TODO. If you
> do, then I hope you like Bash :-)

Sure. It's in. And I like Bash. :-)

Thanks,

-- peterx