From: Joerg Roedel <joro@8bytes.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org,
marc.zyngier@arm.com, robin.murphy@arm.com,
alex.williamson@redhat.com, will.deacon@arm.com,
tglx@linutronix.de, jason@lakedaemon.net,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
drjones@redhat.com, linux-kernel@vger.kernel.org,
pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org,
punit.agrawal@arm.com, diana.craciun@nxp.com
Subject: Re: [RFC v2 8/8] iommu/arm-smmu: implement add_reserved_regions callback
Date: Thu, 10 Nov 2016 17:13:31 +0100 [thread overview]
Message-ID: <20161110161331.GJ2078@8bytes.org> (raw)
In-Reply-To: <04ed9694-707d-260b-70c6-f367d292ceca@redhat.com>
On Thu, Nov 10, 2016 at 04:57:51PM +0100, Auger Eric wrote:
> It does not only serve the purpose to register the MSI IOVA region. We
> also need to allocate an iova_domain where MSI IOVAs will be allocated
> upon the request of the relevant MSI controllers. Do you mean you don't
> like to use the iova allocator for this purpose?
Yes, it looks like the only purpose of iommu_get_dma_msi_region_cookie()
is to get the msi-region information into into the reserved-list.
Why do you need to 'allocate' the MSI region after all? Except for
IOMMU_DOMAIN_DMA domains the iommu-core code does not care about address
allocation. This is up to the users of the domain, which includes that
the user has to take care of the MSI region.
Besides that, 'iommu_get_dma_msi_region_cookie' is a terrible function
name and does not describe at all what the function does or is supposed
to do.
Joerg
next prev parent reply other threads:[~2016-11-10 16:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 11:23 [RFC v2 0/8] KVM PCIe/MSI passthrough on ARM/ARM64 - Alt II Eric Auger
2016-11-04 11:24 ` [RFC v2 3/8] iommu/dma: Allow MSI-only cookies Eric Auger
[not found] ` <1478258646-3117-4-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-14 12:36 ` Robin Murphy
[not found] ` <5f93ebfd-edf4-0b5a-b54a-b96937a588b8-5wv7dgnIgG8@public.gmane.org>
2016-11-14 23:23 ` Auger Eric
2016-11-15 14:52 ` Robin Murphy
[not found] ` <1478258646-3117-1-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-04 11:23 ` [RFC v2 1/8] vfio: fix vfio_info_cap_add/shift Eric Auger
2016-11-04 11:24 ` [RFC v2 2/8] iommu/iova: fix __alloc_and_insert_iova_range Eric Auger
[not found] ` <1478258646-3117-3-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 15:22 ` Joerg Roedel
2016-11-10 15:41 ` Auger Eric
2016-11-04 11:24 ` [RFC v2 4/8] iommu: Add a list of iommu_reserved_region in iommu_domain Eric Auger
[not found] ` <1478258646-3117-5-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-04 14:00 ` Robin Murphy
2016-11-10 11:22 ` Auger Eric
2016-11-10 11:54 ` Robin Murphy
2016-11-10 12:14 ` Auger Eric
[not found] ` <6c2e1c81-e951-a284-b547-733369128e7e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 12:48 ` Robin Murphy
2016-11-10 15:37 ` Joerg Roedel
2016-11-10 15:42 ` Auger Eric
2016-11-04 11:24 ` [RFC v2 5/8] vfio/type1: Introduce RESV_IOVA_RANGE capability Eric Auger
2016-11-04 11:24 ` [RFC v2 7/8] iommu/vt-d: Implement add_reserved_regions callback Eric Auger
2016-11-04 11:24 ` [RFC v2 8/8] iommu/arm-smmu: implement " Eric Auger
2016-11-04 14:16 ` Robin Murphy
[not found] ` <1478258646-3117-9-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-10 15:46 ` Joerg Roedel
[not found] ` <20161110154606.GH2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-10 15:57 ` Auger Eric
2016-11-10 16:13 ` Joerg Roedel [this message]
[not found] ` <20161110161331.GJ2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-10 18:00 ` Auger Eric
[not found] ` <f4537e43-0237-e478-eacd-b107458628b8-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-11 11:42 ` Joerg Roedel
2016-11-11 15:47 ` Auger Eric
2016-11-11 16:22 ` Joerg Roedel
[not found] ` <20161111162211.GU2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-11 16:45 ` Auger Eric
2016-11-14 15:31 ` Joerg Roedel
2016-11-14 16:08 ` Auger Eric
[not found] ` <295feefe-014b-5669-7f5a-e04b09ba3454-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-14 16:20 ` Joerg Roedel
2016-11-14 16:57 ` Auger Eric
2016-11-10 16:07 ` Robin Murphy
[not found] ` <b347ddbc-5066-641c-8101-289fb28624a3-5wv7dgnIgG8@public.gmane.org>
2016-11-10 16:16 ` Joerg Roedel
[not found] ` <20161110161619.GK2078-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-11-11 14:34 ` Robin Murphy
[not found] ` <479aeac0-71f9-a6b8-af6d-e2c25184a818-5wv7dgnIgG8@public.gmane.org>
2016-11-11 15:03 ` Joerg Roedel
2016-11-04 11:24 ` [RFC v2 6/8] iommu: Handle the list of reserved regions Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110161331.GJ2078@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@nxp.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pranav.sawargaonkar@gmail.com \
--cc=punit.agrawal@arm.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).