From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [QEMU PATCH v2] kvmclock: advance clock by time window between
 vm_stop and pre_save
Date: Fri, 11 Nov 2016 12:23:47 -0200
Message-ID: <20161111142344.GA7217@amt.cnet>
References: <20161104094322.GA16930@amt.cnet>
 <20161104165933.GA3027@amt.cnet>
 <20161107154610.GG2054@work-vm>
 <20161107194058.GB28327@amt.cnet>
 <20161107200349.GC1155@work-vm>
 <20161108000609.GA3689@amt.cnet>
 <20161108102255.GC2042@work-vm>
 <4c34da7d-7027-5595-012a-61ab6937f8e3@redhat.com>
 <20161110114826.GA28418@amt.cnet>
 <7e62defb-dcbe-492d-3c05-056b13d6699a@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Juan Quintela <quintela@redhat.com>,
        Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57842 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752357AbcKNMiq (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 07:38:46 -0500
Content-Disposition: inline
In-Reply-To: <7e62defb-dcbe-492d-3c05-056b13d6699a@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 10, 2016 at 06:57:21PM +0100, Paolo Bonzini wrote:
> 
> 
> On 10/11/2016 12:48, Marcelo Tosatti wrote:
> > Destination has to run the following logic:
> > 
> > If (source has KVM_CAP_ADVANCE_CLOCK)
> >     use KVM_GET_CLOCK value
> > Else
> >    read pvclock from guest
> > 
> > To support migration from older QEMU versions which do not have
> > KVM_CAP_ADVANCE_CLOCK (or new QEMU versions running on old
> > hosts without KVM_CAP_ADVANCE_CLOCK).
> > 
> > I don't see any clean way to give that information, except changing
> > the migration format to pass "host: kvm_cap_advance_clock=true/false"
> > information.
> 
> If you make it only affect new machine types, you could transmit a dummy
> clock value such as -1 if the source does not have KVM_CLOCK_TSC_STABLE.
> 
> Paolo

Prefer a new subsection (which is fine since migration is broken
anyway), because otherwise you have to deal with restoring
s->clock from -1 to what was read at KVM_GET_CLOCK (in case
migration fails).