From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v2 03/17] x86: intel-iommu: add vt-d init
 test
Date: Mon, 14 Nov 2016 15:18:32 -0500
Message-ID: <20161114201832.GB3125@pxdev.xzpeter.org>
References: <1478704224-20472-1-git-send-email-peterx@redhat.com>
 <1478704224-20472-4-git-send-email-peterx@redhat.com>
 <20161110190936.bz46qi7g5cij6fmq@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35328 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S937926AbcKNUSe (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 15:18:34 -0500
Content-Disposition: inline
In-Reply-To: <20161110190936.bz46qi7g5cij6fmq@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 10, 2016 at 08:09:36PM +0100, Andrew Jones wrote:

[...]

> > +static uint64_t vtd_root_table(void)
> > +{
> > +       /* No extend root table support yet */
> > +       return vtd_readq(DMAR_RTADDR_REG) & VTD_RTA_MASK;
> 
> Should use tabs. You can run the kernel's scripts/checkpatch.pl,
> since we're using the same coding standard (pretty much...)

Yes, the indentation is wrong, which is to be fixed. Will try the
script later and see what else I can get.

> 
> > +}
> > +
> > +static uint64_t vtd_ir_table(void)
> > +{
> > +	return vtd_readq(DMAR_IRTA_REG) & VTD_IRTA_MASK;
> > +}
> 
> The above two functions are both only used once each. Do we need them?

They are both used in further patches of this series. Also they might
be used in the future as well. So I'll keep them if you would not
mind.

Thanks,

-- peterx