From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH kvm-unit-tests v2 13/17] pci: edu: introduce pci-edu helpers Date: Mon, 14 Nov 2016 15:48:32 -0500 Message-ID: <20161114204832.GG3125@pxdev.xzpeter.org> References: <1478704224-20472-1-git-send-email-peterx@redhat.com> <1478704224-20472-14-git-send-email-peterx@redhat.com> <20161110194503.rbmbetbcurqqykpb@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com, jan.kiszka@web.de, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbcKNUse (ORCPT ); Mon, 14 Nov 2016 15:48:34 -0500 Content-Disposition: inline In-Reply-To: <20161110194503.rbmbetbcurqqykpb@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 10, 2016 at 08:45:03PM +0100, Andrew Jones wrote: [...] > General comment for whole series; I'm not a big fan of the > () around the numeric constants. They're not necessary and > starting to hurt my eyes :-) Sorry for the unmeant hurt. :-( I think I can remove them all in the whole series where apply (I hope I won't miss any). Thanks, -- peterx