From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v2 14/17] x86: intel-iommu: add dmar test
Date: Mon, 14 Nov 2016 15:54:33 -0500
Message-ID: <20161114205433.GH3125@pxdev.xzpeter.org>
References: <1478704224-20472-1-git-send-email-peterx@redhat.com>
 <1478704224-20472-15-git-send-email-peterx@redhat.com>
 <20161110195302.ga42nzxy5iauiqcl@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49064 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752729AbcKNUyg (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 15:54:36 -0500
Content-Disposition: inline
In-Reply-To: <20161110195302.ga42nzxy5iauiqcl@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 10, 2016 at 08:53:02PM +0100, Andrew Jones wrote:

[...]

> > +/* Supported Adjusted Guest Address Widths */
> > +#define VTD_CAP_SAGAW_SHIFT         8
> > + /* 39-bit AGAW, 3-level page-table */
> > +#define VTD_CAP_SAGAW_39bit         (0x2ULL << VTD_CAP_SAGAW_SHIFT)
> > + /* 48-bit AGAW, 4-level page-table */
> 
> The leading space in the above comments is a bit strange

Yes, they are. :)

[...]

> > +	/*
> > +	 * DMA the first 4 bytes of the page to EDU device buffer
> > +	 * offset 0.
> > +	 */
> > +	edu_dma(dev, 0, 4, 0, false);
> 
> missing blank line here

Will fix both. Thanks,

-- peterx