From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v2 15/17] pci: add msi support for
 32/64bit address
Date: Mon, 14 Nov 2016 15:58:05 -0500
Message-ID: <20161114205805.GI3125@pxdev.xzpeter.org>
References: <1478704224-20472-1-git-send-email-peterx@redhat.com>
 <1478704224-20472-16-git-send-email-peterx@redhat.com>
 <20161110201014.kmoj4mhncxwlvigh@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54142 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753175AbcKNU6H (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 15:58:07 -0500
Content-Disposition: inline
In-Reply-To: <20161110201014.kmoj4mhncxwlvigh@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 10, 2016 at 09:10:14PM +0100, Andrew Jones wrote:

[...]

> > +bool pci_setup_msi(struct pci_dev *dev, uint64_t msi_addr, uint32_t msi_data)
> > +{
> > +	uint16_t msi_control;
> > +	uint16_t offset;
> > +	pcidevaddr_t addr = dev->bdf;
> > +
> > +	assert(dev);
> 
> If you're worried that dev might be null then you can't dereference
> it the line above.

Right. Fixing up.

Thanks,

-- peterx