From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v2 17/17] x86/unittests: add intel-iommu
 test
Date: Mon, 14 Nov 2016 16:07:51 -0500
Message-ID: <20161114210751.GJ3125@pxdev.xzpeter.org>
References: <1478704224-20472-1-git-send-email-peterx@redhat.com>
 <1478704224-20472-18-git-send-email-peterx@redhat.com>
 <20161110202141.t76gr5ibj4omrizg@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, agordeev@redhat.com,
        jan.kiszka@web.de, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54564 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932462AbcKNVHy (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 14 Nov 2016 16:07:54 -0500
Content-Disposition: inline
In-Reply-To: <20161110202141.t76gr5ibj4omrizg@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 10, 2016 at 09:21:41PM +0100, Andrew Jones wrote:
> On Wed, Nov 09, 2016 at 10:10:24AM -0500, Peter Xu wrote:
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  x86/unittests.cfg | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index 23395c6..5413838 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -217,3 +217,10 @@ extra_params = -cpu kvm64,hv_time,hv_synic,hv_stimer -device hyperv-testdev
> >  file = hyperv_clock.flat
> >  smp = 2
> >  extra_params = -cpu kvm64,hv_time
> > +
> > +[intel_iommu]
> > +file = intel-iommu.flat
> > +arch = x86_64
> > +timeout = 30
> > +smp = 4
> > +extra_params = -M q35,kernel-irqchip=split -device intel-iommu,intremap=on,eim=off -device edu
> > -- 
> > 2.7.4
> >
> 
> I haven't looked up eim=off means, whether or not we want it, but
> otherwise it looks good to me.

When set eim=off, x2apic will be disabled. So basically "eim" bit is
to configure whether we want to support x2apic in the guest, in case
we want to use more than 255 vcpus.

Here:

- if with eim=off, vt-d test will need latest QEMU to run (so if with
  older QEMUs, it'll fail)

- if without eim=off, vt-d test will need latest KVM to run (so if
  with older KVM, it'll fail)

I just chose the 1st one since I guess a latest QEMU is easier to get
and compile than kernel.

Thanks,

-- peterx