kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, agordeev@redhat.com, jan.kiszka@web.de,
	rkrcmar@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v3 09/13] pci: provide pci_enable_defaults()
Date: Tue, 15 Nov 2016 11:42:43 -0500	[thread overview]
Message-ID: <20161115164243.GD19487@pxdev.xzpeter.org> (raw)
In-Reply-To: <20161115085840.pmqqpmo6ftlup65t@kamzik.brq.redhat.com>

On Tue, Nov 15, 2016 at 09:58:40AM +0100, Andrew Jones wrote:

[...]

> > @@ -25,6 +25,8 @@ struct pci_dev {
> >  
> >  void pci_dev_init(struct pci_dev *dev, pcidevaddr_t bdf);
> >  void pci_scan_bars(struct pci_dev *dev);
> > +void pci_cmd_set_clr(struct pci_dev *dev, uint16_t set, uint16_t clr);
> > +void pci_enable_defaults(struct pci_dev *dev);
> 
> Don't forget the [pointless] externs on these functions for this patch,
> and the ones that introduced the functions above.

Adding all of them missing for pci.h. Actually I see there's still one
missing:

  int pci_testdev(void);

But I won't touch it since that's irrelevant to this series (and I am
always okay /wo "extern" :).

[...]

> Reviewed-by: Andrew Jones <drjones@redhat.com>

Adding this too. Thanks,

-- peterx

  reply	other threads:[~2016-11-15 16:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 22:27 [PATCH v3 00/13] VT-d unit test Peter Xu
2016-11-14 22:27 ` [PATCH v3 01/13] x86/asm: add cpu_relax() Peter Xu
2016-11-14 22:28 ` [PATCH v3 02/13] libcflat: introduce is_power_of_2() Peter Xu
2016-11-14 22:28 ` [PATCH v3 03/13] x86: intel-iommu: add vt-d init test Peter Xu
2016-11-15  8:41   ` Andrew Jones
2016-11-14 22:28 ` [PATCH v3 04/13] libcflat: add IS_ALIGNED() macro, and page sizes Peter Xu
2016-11-15  8:43   ` Andrew Jones
2016-11-15 16:26     ` Peter Xu
2016-11-14 22:28 ` [PATCH v3 05/13] libcflat: moving MIN/MAX here Peter Xu
2016-11-14 22:28 ` [PATCH v3 06/13] vm/page: provide PGDIR_OFFSET() macro Peter Xu
2016-11-14 22:28 ` [PATCH v3 07/13] pci: introduce struct pci_dev Peter Xu
2016-11-14 22:28 ` [PATCH v3 08/13] pci: provide pci_scan_bars() Peter Xu
2016-11-15  8:54   ` Andrew Jones
2016-11-15 16:32     ` Peter Xu
2016-11-14 22:28 ` [PATCH v3 09/13] pci: provide pci_enable_defaults() Peter Xu
2016-11-15  8:58   ` Andrew Jones
2016-11-15 16:42     ` Peter Xu [this message]
2016-11-15 17:15       ` Andrew Jones
2016-11-14 22:28 ` [PATCH v3 10/13] pci: edu: introduce pci-edu helpers Peter Xu
2016-11-15  9:02   ` Andrew Jones
2016-11-14 22:28 ` [PATCH v3 11/13] x86: intel-iommu: add dmar test Peter Xu
2016-11-15  9:08   ` Andrew Jones
2016-11-15 17:01     ` Peter Xu
2016-11-14 22:28 ` [PATCH v3 12/13] pci: add msi support for 32/64bit address Peter Xu
2016-11-15  9:10   ` Andrew Jones
2016-11-14 22:28 ` [PATCH v3 13/13] x86: intel-iommu: add IR MSI test Peter Xu
2016-11-15  9:13   ` Andrew Jones
2016-11-14 22:36 ` THIS SERIES SHOULD BE: "[PATCH v4 00/13] VT-d unit test" Peter Xu
2016-11-15  9:17 ` [PATCH v3 00/13] VT-d unit test Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115164243.GD19487@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=agordeev@redhat.com \
    --cc=drjones@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).