From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v3 09/13] pci: provide pci_enable_defaults()
Date: Tue, 15 Nov 2016 11:42:43 -0500
Message-ID: <20161115164243.GD19487@pxdev.xzpeter.org>
References: <1479162491-20764-1-git-send-email-peterx@redhat.com>
 <1479162491-20764-10-git-send-email-peterx@redhat.com>
 <20161115085840.pmqqpmo6ftlup65t@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, agordeev@redhat.com, jan.kiszka@web.de,
        rkrcmar@redhat.com, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58074 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753059AbcKOQmp (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 15 Nov 2016 11:42:45 -0500
Content-Disposition: inline
In-Reply-To: <20161115085840.pmqqpmo6ftlup65t@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Nov 15, 2016 at 09:58:40AM +0100, Andrew Jones wrote:

[...]

> > @@ -25,6 +25,8 @@ struct pci_dev {
> >  
> >  void pci_dev_init(struct pci_dev *dev, pcidevaddr_t bdf);
> >  void pci_scan_bars(struct pci_dev *dev);
> > +void pci_cmd_set_clr(struct pci_dev *dev, uint16_t set, uint16_t clr);
> > +void pci_enable_defaults(struct pci_dev *dev);
> 
> Don't forget the [pointless] externs on these functions for this patch,
> and the ones that introduced the functions above.

Adding all of them missing for pci.h. Actually I see there's still one
missing:

  int pci_testdev(void);

But I won't touch it since that's irrelevant to this series (and I am
always okay /wo "extern" :).

[...]

> Reviewed-by: Andrew Jones <drjones@redhat.com>

Adding this too. Thanks,

-- peterx