Re: [PATCH v3 11/13] x86: intel-iommu: add dmar test

[Peter Xu <peterx@redhat.com>]

On Tue, Nov 15, 2016 at 10:08:41AM +0100, Andrew Jones wrote:

[...]

> > +static void vtd_install_pte(vtd_pte_t *root, iova_t iova,
> > +			    phys_addr_t pa, int level_target)
> > +{
> > +	int level;
> > +	unsigned int offset;
> > +	void *page;
> > +
> > +	for (level = VTD_PAGE_LEVEL; level > level_target; level--) {
> > +		offset = PGDIR_OFFSET(iova, level);
> > +		if (!(root[offset] & VTD_PTE_RW)) {
> > +			page = alloc_page();
> > +			memset(page, 0, PAGE_SIZE);
> > +			root[offset] = virt_to_phys(page) | VTD_PTE_RW;
> > +		}
> > +		root = (uint64_t *)(root[offset] & VTD_PTE_ADDR);
> > +	}
> > +
> > +	offset = PGDIR_OFFSET(iova, level);
> > +	root[offset] = pa | VTD_PTE_RW;
> > +	if (level != 1)
> > +		/* This is huge page */
> > +		root[offset] |= VTD_PTE_HUGE;
> 
> I'd use {} on this if because you have two lines (even though one is
> a comment)

Hmm obviously I missed this one. Thanks,

-- peterx