From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v3 11/13] x86: intel-iommu: add dmar test
Date: Tue, 15 Nov 2016 12:01:16 -0500
Message-ID: <20161115170116.GE19487@pxdev.xzpeter.org>
References: <1479162491-20764-1-git-send-email-peterx@redhat.com>
 <1479162491-20764-12-git-send-email-peterx@redhat.com>
 <20161115090841.isysm5esgsjhg7ma@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, agordeev@redhat.com, jan.kiszka@web.de,
        rkrcmar@redhat.com, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:38442 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751884AbcKORBS (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 15 Nov 2016 12:01:18 -0500
Content-Disposition: inline
In-Reply-To: <20161115090841.isysm5esgsjhg7ma@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Nov 15, 2016 at 10:08:41AM +0100, Andrew Jones wrote:

[...]

> > +static void vtd_install_pte(vtd_pte_t *root, iova_t iova,
> > +			    phys_addr_t pa, int level_target)
> > +{
> > +	int level;
> > +	unsigned int offset;
> > +	void *page;
> > +
> > +	for (level = VTD_PAGE_LEVEL; level > level_target; level--) {
> > +		offset = PGDIR_OFFSET(iova, level);
> > +		if (!(root[offset] & VTD_PTE_RW)) {
> > +			page = alloc_page();
> > +			memset(page, 0, PAGE_SIZE);
> > +			root[offset] = virt_to_phys(page) | VTD_PTE_RW;
> > +		}
> > +		root = (uint64_t *)(root[offset] & VTD_PTE_ADDR);
> > +	}
> > +
> > +	offset = PGDIR_OFFSET(iova, level);
> > +	root[offset] = pa | VTD_PTE_RW;
> > +	if (level != 1)
> > +		/* This is huge page */
> > +		root[offset] |= VTD_PTE_HUGE;
> 
> I'd use {} on this if because you have two lines (even though one is
> a comment)

Hmm obviously I missed this one. Thanks,

-- peterx