From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2] runtime: better handling of QEMU aborts
Date: Wed, 16 Nov 2016 21:47:29 +0100
Message-ID: <20161116204728.GC20282@potion>
References: <1479230784-5640-1-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, peter.maydell@linaro.org
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59072 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S936237AbcKPUrc (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 16 Nov 2016 15:47:32 -0500
Content-Disposition: inline
In-Reply-To: <1479230784-5640-1-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-11-15 18:26+0100, Andrew Jones:
> Add two changes to run_qemu. The first saves/restores terminal settings.
> This solves an annoying loss of terminal echo when QEMU aborts during
> a test run. The second ensures we see a message about the abort, because
> the "Aborted (core dumped)" message we should see gets eaten. We also
> add a message to run()'s failure cases in its exit code processing to
> handle signals in general.
> 
> Note, the first change is necessary because QEMU modifies the terminal
> settings when using '-serial stdio', but calling abort() invokes exit
> without first calling qemu_chr_free(serial_hds[0]) to restore them.
> 
> (Additionally we fixup the premature failure check to only capture the
>  last line, like it says it's doing.)
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> ---
> v2:
>  - rebase to latest master and add FAIL case to run()'s exit code
>    processing [Radim]
>  - add '>(tail -1) to premature failure check [Radim]
> ---
> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> @@ -26,13 +26,16 @@
>  ##############################################################################
>  run_qemu ()
>  {
> -	local stdout errors ret sig
> +	local stdout errors ret sig tty
>  
>  	# stdout to {stdout}, stderr to $errors and stderr
> +	tty=$(stty -g)
>  	exec {stdout}>&1
>  	errors=$("${@}" 2> >(tee /dev/stderr) > /dev/fd/$stdout)
>  	ret=$?
> +	[ $ret -eq 134 ] && echo "QEMU Aborted" > /dev/fd/$stdout

Standard output is /dev/fd/$stdout here (unlike in parentheses, where it
was $errors).  I can remove the redirection when applying, but
redirecting to stderr would also make sense -- what do you prefer?

>  	exec {stdout}>&-
> +	stty "$tty"
>  
>  	if [ "$errors" ]; then
>  		sig=$(grep 'terminating on signal' <<<"$errors")