From: Alex Williamson <alex.williamson@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Jike Song <jike.song@intel.com>,
cjia@nvidia.com, kvm@vger.kernel.org, qemu-devel@nongnu.org,
linux-kernel@vger.kernel.org, kevin.tian@intel.com,
kraxel@redhat.com, pbonzini@redhat.com,
bjsdjshi@linux.vnet.ibm.com
Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev
Date: Thu, 17 Nov 2016 09:14:53 -0700 [thread overview]
Message-ID: <20161117091453.6e9de7c2@t450s.home> (raw)
In-Reply-To: <27bfa26c-4d57-7f64-a489-f3d341d00fea@nvidia.com>
On Thu, 17 Nov 2016 21:30:26 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:
> On 11/17/2016 8:57 PM, Alex Williamson wrote:
> > On Thu, 17 Nov 2016 20:35:38 +0800
> > Jike Song <jike.song@intel.com> wrote:
> >
> >> On 11/17/2016 04:46 AM, Kirti Wankhede wrote:
> >>> Add a notifier calback to parent's ops structure of mdev device so that per
> >>> device notifer for vfio module is registered through vfio_mdev module.
> >>>
> >>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> >>> Signed-off-by: Neo Jia <cjia@nvidia.com>
> >>> Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
> >>> ---
> >>> drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++-
> >>> include/linux/mdev.h | 9 +++++++++
> >>> 2 files changed, 42 insertions(+), 1 deletion(-)
> >>>
> >>
> >> Hi Alex, Kirti,
> >>
> >> Since everyone agreed we should let the vendor driver call vfio_register_notifier
> >> directly, can you drop this patch from merging? So that I don't need to send a
> >> reverse patch.
> >
> > This seems like a reasonable request to me, this patch drops cleanly
> > from the series. Any objection Kirti? It seems like it removes a
> > little bit of pre-release churn from the API. Thanks,
> >
>
> This is independent patch, I don't have any concern to drop this patch.
>
> Small nit: Since Documentation patch is later in series, its mentioned
> in the doc. One line need to be removed from vfio-mediated-device.txt.
>
> --- a/Documentation/vfio-mediated-device.txt
> +++ b/Documentation/vfio-mediated-device.txt
> @@ -150,7 +150,6 @@ The callbacks in the parent_ops structure are as
> follows:
> * read : read emulation callback
> * write: write emulation callback
> * mmap: mmap emulation callback
> -* notifier: notifier callback
Good catch, I'll remove this line. Thanks,
Alex
next prev parent reply other threads:[~2016-11-17 16:14 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 20:46 [PATCH v14 00/22] Add Mediated device support Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 01/22] vfio: Mediated device Core driver Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 02/22] vfio: VFIO based driver for Mediated devices Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 03/22] vfio: Rearrange functions to get vfio_group from dev Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 04/22] vfio: Common function to increment container_users Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 06/22] vfio iommu type1: Update arguments of vfio_lock_acct Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 07/22] vfio iommu type1: Update argument of vaddr_get_pfn() Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 08/22] vfio iommu type1: Add find_iommu_group() function Kirti Wankhede
2016-11-21 11:29 ` Auger Eric
2016-11-21 11:55 ` Kirti Wankhede
2016-11-21 12:42 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 09/22] vfio iommu type1: Add task structure to vfio_dma Kirti Wankhede
2016-11-17 5:41 ` Alexey Kardashevskiy
2016-11-17 6:12 ` Alex Williamson
2016-11-17 6:42 ` Alexey Kardashevskiy
2016-11-17 6:23 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 10/22] vfio iommu type1: Add support for mediated devices Kirti Wankhede
2016-11-16 23:57 ` Alex Williamson
2016-11-17 4:49 ` Kirti Wankhede
2016-11-17 4:52 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP Kirti Wankhede
2016-11-17 0:02 ` Alex Williamson
2016-11-17 2:53 ` Jike Song
2016-11-17 4:58 ` Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev Kirti Wankhede
2016-11-17 2:15 ` Dong Jia Shi
2016-11-17 5:04 ` Kirti Wankhede
[not found] ` <20161117021533.GD6620@bjsdjshi@linux.vnet.ibm.com>
2016-11-17 5:05 ` Kirti Wankhede
2016-11-17 12:35 ` Jike Song
2016-11-17 15:27 ` Alex Williamson
2016-11-17 16:00 ` Kirti Wankhede
2016-11-17 16:14 ` Alex Williamson [this message]
2016-11-16 20:46 ` [PATCH v14 13/22] vfio: Introduce common function to add capabilities Kirti Wankhede
2016-11-21 11:04 ` [Qemu-devel] " Auger Eric
2016-11-16 20:46 ` [PATCH v14 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability() Kirti Wankhede
2016-11-21 11:04 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare() Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare() Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 17/22] vfio_platform: " Kirti Wankhede
2016-11-21 10:51 ` Auger Eric
2016-11-16 20:46 ` [PATCH v14 18/22] vfio: Define device_api strings Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 19/22] docs: Add Documentation for Mediated devices Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 20/22] docs: Sysfs ABI for mediated device framework Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 21/22] docs: Sample driver to demonstrate how to use Mediated " Kirti Wankhede
2016-11-16 20:46 ` [PATCH v14 22/22] MAINTAINERS: Add entry VFIO based Mediated device drivers Kirti Wankhede
2016-11-17 21:25 ` [PATCH v14 00/22] Add Mediated device support Alex Williamson
2016-11-17 22:05 ` Neo Jia
2016-11-18 2:00 ` Kirti Wankhede
2016-11-18 2:26 ` [Qemu-devel] " Jike Song
2016-11-17 23:29 ` Tian, Kevin
2016-11-17 23:51 ` Alex Williamson
2016-11-18 2:59 ` Dong Jia Shi
2016-11-18 9:16 ` Zhenyu Wang
2016-11-18 15:40 ` Alex Williamson
2016-11-18 16:09 ` Daniel Vetter
2016-11-18 16:50 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117091453.6e9de7c2@t450s.home \
--to=alex.williamson@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cjia@nvidia.com \
--cc=jike.song@intel.com \
--cc=kevin.tian@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).