From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Edwards Subject: Re: [4.1.y] vmwrite error: reg 401e value a9 (err 1) Date: Thu, 17 Nov 2016 09:12:54 -0700 Message-ID: <20161117161254.GA3425@psuche> References: <20161109001702.GA24512@psuche> <5dce69ed-3f0d-95af-10bc-b91b3a5f711f@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "Huang, Kai" , , "Sasha Levin" , Radim =?utf-8?B?S3LEjW3DocWZ?= , Jim Mattson , To: Paolo Bonzini Return-path: Received: from legacy.ddn.com ([64.47.133.206]:32883 "EHLO legacy.ddn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbcKQQ6H (ORCPT ); Thu, 17 Nov 2016 11:58:07 -0500 Content-Disposition: inline In-Reply-To: <5dce69ed-3f0d-95af-10bc-b91b3a5f711f@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 17, 2016 at 01:41:12PM +0100, Paolo Bonzini wrote: > On 09/11/2016 04:10, Huang, Kai wrote: >> Hi Greg, >> >> Thanks for reporting this issue. >> >> I don't have 4.1.y source code tree at hand but after taking a glance >> looks the commit a3eaa8649e4c6a6afdafaa04b9114fb230617bb1 ("KVM: VMX: >> Fix commit which broke PML") fixes this by removing vmwrite to >> SECONDARY_VM_EXEC_CONTROL in vmx_disable_pml, so yes I think this commit >> can fix this issue. >> >> But I think you probably need another commit to fix potential vmwrite >> error when creating vcpu: 4e59516a12a6ef6dcb660cb3a3f70c64bd60cfec (kvm: >> vmx: ensure VMCS is current while enabling PML). Peter found and fixed >> this issue, so I also added him to cc-list. >> >> Paolo/Radim, please comment if I made mistake here. > > Yes, we should backport both of them. Greg, can you test it? Then I'll > send the two patches to linux-stable. Yes, we've been running with both patches internally without problems for a week or so. Greg