From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [kvm-unit-tests PATCH] report: introduce report_info Date: Tue, 22 Nov 2016 14:32:51 +0100 Message-ID: <20161122133250.GB12949@potion> References: <1479476154-25596-1-git-send-email-drjones@redhat.com> <78be2560-79b5-4831-7846-f521cac93631@redhat.com> <20161118142658.qe4jo6lv35crmtmy@kamzik.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Huth , kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com, andre.przywara@arm.com To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755807AbcKVNcz (ORCPT ); Tue, 22 Nov 2016 08:32:55 -0500 Content-Disposition: inline In-Reply-To: <20161118142658.qe4jo6lv35crmtmy@kamzik.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-11-18 15:26+0100, Andrew Jones: > On Fri, Nov 18, 2016 at 03:20:24PM +0100, Thomas Huth wrote: >> On 18.11.2016 14:35, Andrew Jones wrote: >> > Test writers sometimes want to output informational messages, but >> > they don't want to use printf because they want the prefixes as >> > well. Rather than creating "fake" tests that always pass, with >> > report(fmt, true, ...), provide report_info(fmt, ...). This >> > generates 'INFO: prefixes...: message' >> > >> > While touching report code also add the lock to report_abort to >> > ensure its output line integrity. >> >> Since repor_abort() is a different topic, I'd suggest to move that hunk >> into a different patch instead. > > Yeah, I was being a big lazy there. I can respin with lazy-mode disabled, > if you like, but I'll stay lazy just a little longer to see if Radim/Paolo > take it as is :-) I'd prefer two patches as well. Laziness is good, though ... If you stay lazy for more than a week from now, I'll apply v1 with a note that we all agreed that this is not how patches should be split.